Re: [PATCH net-next v4 2/2] netcons: Add udp send fail statistics to netconsole

[Jakub Kicinski]

On Sun, 27 Oct 2024 12:59:42 -0700 Maksym Kutsevol wrote:
> +struct netconsole_target_stats  {
> +	u64_stats_t xmit_drop_count;
> +	u64_stats_t enomem_count;
> +	struct u64_stats_sync syncp;
> +} __aligned(2 * sizeof(u64));

Why the alignment?

> +static void netpoll_send_udp_count_errs(struct netconsole_target *nt,
> +					const char *msg, int len)

This is defined in the netconsole driver, it should not use the
netpoll_ prefix for the function name.