Re: [PATCH v1 1/2] ethernet: arc: fix the device for dma_map_single/dma_unmap_single

From: Andrew Lunn
Date: Mon Oct 28 2024 - 09:03:37 EST


On Sun, Oct 27, 2024 at 10:41:48AM +0100, Johan Jonker wrote:
> The ndev->dev and pdev->dev aren't the same device, use ndev->dev.parent
> which has dma_mask, ndev->dev.parent is just pdev->dev.
> Or it would cause the following issue:
>
> [ 39.933526] ------------[ cut here ]------------
> [ 39.938414] WARNING: CPU: 1 PID: 501 at kernel/dma/mapping.c:149 dma_map_page_attrs+0x90/0x1f8
>
> Signed-off-by: David Wu <david.wu@xxxxxxxxxxxxxx>
> Signed-off-by: Johan Jonker <jbx6244@xxxxxxxxx>

A few process issues:

For a patch set please add a patch 0/X which explains the big picture
of what the patchset does. For a single patch, you don't need one.

Please read:

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

It is not clear which tree you intend these patches to be applied
to. This one looks like it should be to net, but needs a Fixes:
tag. The MDIO patch might be for net-next?

Andrew

---
pw-bot: cr