Re: Re: [PATCH v1 2/2] net: arc: rockchip: fix emac mdio node support
From: Andrew Lunn
Date: Tue Oct 29 2024 - 08:47:22 EST
On Tue, Oct 29, 2024 at 04:22:16PM +0800, Andy Yan wrote:
>
> Hi Andrew,
>
> At 2024-10-28 20:59:18, "Andrew Lunn" <andrew@xxxxxxx> wrote:
> >> Hello Johan,
> >> Thanks for your patch. Maybe we need a Fixes tag here?
> >
> >What is actually broken?
>
> The emac failed to probe after bellow patch merged.
>
> [ 2.324583] loop: module loaded
> [ 2.328435] SPI driver spidev has no spi_device_id for rockchip,spidev
> [ 2.338688] tun: Universal TUN/TAP device driver, 1.6
> [ 2.345397] rockchip_emac 10200000.ethernet: no regulator found
> [ 2.351892] rockchip_emac 10200000.ethernet: ARC EMAC detected with id: 0x7fd02
> [ 2.359331] rockchip_emac 10200000.ethernet: IRQ is 43
> [ 2.364719] rockchip_emac 10200000.ethernet: MAC address is now e6:58:d6:ec:d9:7c
> [ 2.396993] mdio_bus Synopsys MII Bus: mdio has invalid PHY address
> [ 2.403306] mdio_bus Synopsys MII Bus: scan phy mdio at address 0
> [ 2.508656] rockchip_emac 10200000.ethernet: of_phy_connect() failed
> [ 2.516334] rockchip_emac 10200000.ethernet: failed to probe arc emac (-19)
So it is failing to find the PHY, and given the 'mdio has invalid PHY
address' it is probably looking in the wrong node.
The commit message should explain this.
Andrew