Re: [PATCH v3 12/17] wifi: cc33xx: Add scan.c, scan.h

[Nemanov, Michael]

On 8/9/2024 7:03 PM, Simon Horman wrote:
> On Tue, Aug 06, 2024 at 08:00:13PM +0300, Michael Nemanov wrote:
>
> ...
>
> > diff --git a/drivers/net/wireless/ti/cc33xx/scan.h b/drivers/net/wireless/ti/cc33xx/scan.h
>
> ...
>
> > +/**
> > + * struct cc33xx_cmd_ssid_list - scan SSID list description
> > + *
> > + * @role_id:            roleID
> > + *
> > + * @num_of_ssids:       Number of SSID in the list. MAX 16 entries
>
> @num_of_ssids -> @n_ssids
>
> > + *
> > + * @ssid_list:          SSIDs to scan for (active scan only)
>
> @ssid_list -> @ssids
>

Thanks for the feedback, will fix.

> Please document all non-private fields,
> and annotate those that are private.

Not sure I follow. You mean mark private vs. non private members in the 
documentation? If so, private to what (the CC33xx driver or the 
underlying HW)?

> There are a number of similar minor Kernel doc problems with this patch.
> Please consider using W=1 builds or ./scripts/kernel-doc -none
> (bonus points for -Wall)

Ran both, got warning for "no structured comments found" on multiple 
files. Is that it?

Thanks and regards,
Michael.