Re: [PATCH 1/2] clocksource: Add Ralink System Tick Counter driver

From: Daniel Lezcano
Date: Mon Oct 28 2024 - 12:29:23 EST


On 20/09/2024 09:53, Sergio Paracuellos wrote:
System Tick Counter is present on Ralink SoCs RT3352 and MT7620. This
driver has been in 'arch/mips/ralink' directory since the beggining of
Ralink architecture support. However, it can be moved into a more proper
place in 'drivers/clocksource'. Hence add it here adding also support for
compile test targets.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx>
---
drivers/clocksource/Kconfig | 10 ++
drivers/clocksource/Makefile | 1 +
drivers/clocksource/timer-ralink.c | 150 +++++++++++++++++++++++++++++
3 files changed, 161 insertions(+)
create mode 100644 drivers/clocksource/timer-ralink.c

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 95dd4660b5b6..50339f4d3201 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -753,4 +753,14 @@ config EP93XX_TIMER
Enables support for the Cirrus Logic timer block
EP93XX.
+config CLKSRC_RALINK

It is a timer

RALINK_TIMER

+ bool "Ralink System Tick Counter"

Silent option please if possible.

Let the platform Kconfig selects the driver

+ depends on SOC_RT305X || SOC_MT7620 || COMPILE_TEST
+ default y if SOC_RT305X || SOC_MT7620

You should have something similar the RISCV option, no default option

+ select CLKSRC_MMIO
+ select TIMER_OF
+ help
+ Enables support for system tick counter present on
+ Ralink SoCs RT3352 and MT7620.
+
endmenu
diff --git a/drivers/clocksource/Makefile b/drivers/clocksource/Makefile
index 22743785299e..c9214afcb712 100644
--- a/drivers/clocksource/Makefile

You should use git mv

Otherwise the code is like submitting a new driver



--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog