Re: [PATCH v6] rust: add global lock support

From: Alice Ryhl
Date: Tue Oct 29 2024 - 10:18:01 EST


On Mon, Oct 28, 2024 at 6:49 PM Boqun Feng <boqun.feng@xxxxxxxxx> wrote:
>
> On Wed, Oct 23, 2024 at 01:23:18PM +0000, Alice Ryhl wrote:
> > Add support for creating global variables that are wrapped in a mutex or
> > spinlock.
> >
> > The implementation here is intended to replace the global mutex
> > workaround found in the Rust Binder RFC [1]. In both cases, the global
> > lock must be initialized before first use. The macro is unsafe to use
> > for the same reason.
> >
> > The separate initialization step is required because it is tricky to
> > access the value of __ARCH_SPIN_LOCK_UNLOCKED from Rust. Doing so will
> > require changes to the C side. That change will happen as a follow-up to
> > this patch.
> >
> > Link: https://lore.kernel.org/rust-for-linux/20231101-rust-binder-v1-2-08ba9197f637@xxxxxxxxxx/#Z31drivers:android:context.rs [1]
> > Signed-off-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
>
> Reviewed-by: Boqun Feng <boqun.feng@xxxxxxxxx>

Thanks!

Alice