Re: [PATCH v6] rust: add global lock support
From: Miguel Ojeda
Date: Tue Oct 29 2024 - 14:48:54 EST
On Mon, Oct 28, 2024 at 6:49 PM Boqun Feng <boqun.feng@xxxxxxxxx> wrote:
>
> Reviewed-by: Boqun Feng <boqun.feng@xxxxxxxxx>
>
> In addition, I've also queued it in my lockdep-for-tip branch:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/boqun/linux.git/log/?h=lockdep-for-tip
>
> as I want to help route Rust lock-related patches into tip, so this is
> a practice round for me ;-)
>
> Miguel, feel free to take it via rust-next with my Reviewed-by, I will
> drop it from my branch once if I see it shows up in v6.13-rc1.
No, no, it is great if you can take them :)
By "if I see it shows up in v6.13-rc1", do you mean your branch is not
meant for v6.13?
Couple of things I noticed that I would normally double-check/fix in
place: the "// SAFETY: called exactly once" comment could be
formatted, and I think the "Link:" tag should be before your SoB
(well, at least b4 does that, which makes sense since you added it,
but I have seen commits done differently too).
Thanks!
Cheers,
Miguel