Re: [PATCH v2 1/1] PM: EM: Add min/max available performance state limits

From: Rafael J. Wysocki
Date: Wed Oct 30 2024 - 07:23:26 EST


On Wed, Oct 30, 2024 at 11:00 AM Lukasz Luba <lukasz.luba@xxxxxxx> wrote:
>
> On 10/30/24 08:48, Lukasz Luba wrote:
> > Hi Rafael,
> >
> > On 10/29/24 18:29, Rafael J. Wysocki wrote:
> >> On Tue, Oct 29, 2024 at 10:43 AM Lukasz Luba <lukasz.luba@xxxxxxx> wrote:
> >>>
>
> [snip]
>
> >>> +EXPORT_SYMBOL_GPL(em_update_performance_limits);
> >>
> >> It would be good to have at least one caller of this function in the
> >> tree.
> >
> > Yes, I know, but we had delays with the SCMI cpufreq to get the
> > notifications support, which are sent from FW...
> >
> > The patch using this API was part of v1 but with assumption that
> > those SCMI notifications are merged.
> >
> > The patch v1 for the SCMI cpufreq driver [1].
> >
> > In that v1 cover letter I mentioned that the 2nd patch depends
> > on notifications [2].
> >
> > I will have to work with Cristian on that notification in SCMI
> > then this API will be used. I can see that it stuck for a while
> > in v5. Let me sort that out (probably not in this merge window
> > though).
>
> Just to link the effort which has been started into that direction:
>
> https://lore.kernel.org/lkml/ab36709d-a181-4621-a8e5-0ef38b80186b@xxxxxxx/

OK, then this can be queued up as a prerequisite for the upcoming changes.

I would, however, mention that in the patch changelog and add a Link:
tag pointing to the above.

> > [1]
> > https://lore.kernel.org/lkml/20240403162315.1458337-3-lukasz.luba@xxxxxxx/
> > [2]
> > https://lore.kernel.org/lkml/20240403162315.1458337-1-lukasz.luba@xxxxxxx/
> > [3]
> > https://lore.kernel.org/lkml/20240603192654.2167620-1-quic_sibis@xxxxxxxxxxx/
> >