Re: [PATCH 0/5] Implement setup_inteface() in the DaVinci NAND controller

[Bastien Curutchet]

Hi Krzysztof,

On 10/30/24 12:17 PM, Krzysztof Kozlowski wrote:
> On 30/10/2024 11:47, Bastien Curutchet wrote:
> > Hi all,
> >
> > This patch series aims to implement the setup_interface() operation in
> > the DaVinci NAND controller to enable the use of all ONFI modes and
> > improve the NAND access speed.
>
> Your changelog is supposed to explain also merging dependencies. Within
> patchset or external.

I'm not sure I understand what you mean here. Do you mean that I need to 
explicitly state that the patches in the 
drivers/mtd/nand/raw/davinci_nand.c depend on the ones in 
drivers/memory/ti-aemif.c ?

There isn't any external dependency on this patch series. The ONFI modes 
are already managed by the NAND core driver (in 
drivers/mtd/nand/raw/nand_base.c). If a NAND controller wants to benefit 
from all the ONFI modes, it needs to implement the setup_interface() 
operation; otherwise it can only use the mode 0 which is the slowest.

> > This NAND controller is present in the DaVinci (OMAP L138) and Keystone2
> > SoCs and functions as a 'child' of the AEMIF controller. So its timings
> > are set by the AEMIF controller itself from device-tree properties.
> > Implementing the setup_interface() callback implies being able to update
> > dynamically these timings, so the first two patches of the series modify
> > the AEMIF driver to provide its 'children' a way to modify their chip
> > select timing configuration. To do so, I add a ti-aemif.h header, I'm not
> > sure whether this header should be located in include/memory or in
> > include/linux/memory. I put it in include/memory because the folder
> > already exists while include/linux/memory doesn't.
>
> All Linux headers go to include/linux/, so this one should as well.

Ok thank you, I'll move it there in V2.


Best regards,
Bastien