Re: [RFC net-next v01 1/1] net: hinic3: Add a driver for Huawei 3rd gen NIC

[Andrew Lunn]

> To properly review (error prone) pause it would be better to remove it from
> initial submission and add it in a later dedicated submission.

Not really. It should be in a patch titled ethtool, so it is easy to
find. And since i've pointed out most drivers get it wrong, you will
assume you also have it wrong, assign a developer to go read the
discussion on the netdev list where i point out drivers which get it
wrong and what is the correct implementation, your developer will then
fixup your code if needed, and all i need to do is confirm you got it
right. Or shake my head and say despite the warning, it is still
wrong. 

	Andrew