Re: [RFC net-next v01 1/1] net: hinic3: Add a driver for Huawei 3rd gen NIC

From: Jakub Kicinski
Date: Sun Nov 03 2024 - 17:19:51 EST


On Sun, 3 Nov 2024 22:17:55 +0200 Gur Stavi wrote:
> Breaking a 10KLoC submission into a few 4KLcC (or less) patches helps to
> review specific patches (and ignore other patches) but all lines still need
> to be approved at once so someone must review them.
>
> Breaking 10KLoC into multiple submissions is easier to review and approve
> (in parts), but merged code will be non-functional until the last
> submission.
> It will compile fine, do no harm, and nobody will pick it except for allyes
> builds.

The driver not being fully functional after the first submission is
fine.

This is a better example, although some parts could have still be
delayed to the second chunk:

https://lore.kernel.org/all/172054602727.1305884.10973465571854855750.stgit@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx/