Re: [PATCH net-next v1 1/1] nfc: mrvl: Don't use "proxy" headers

[Andy Shevchenko]

On Sat, Nov 02, 2024 at 09:00:04AM +0100, Krzysztof Kozlowski wrote:
> On 01/11/2024 09:39, Andy Shevchenko wrote:
> > Update header inclusions to follow IWYU (Include What You Use)
> > principle.

...

> > -#include <linux/module.h>
> >  #include <linux/delay.h>
> > -#include <linux/of_gpio.h>
> > +#include <linux/device.h>
> > +#include <linux/err.h>
> > +#include <linux/module.h>
> > +#include <linux/of.h>
> > +#include <linux/printk.h>
> 
> Do we really include printk?

Yes, we use it here.

> It's almost everywhere and pulled by kernel.h.

kernel.h shouldn't be considered at all, it's a mess which is on undergoing
cleaning up process.


> I assume you checked rest of the nfcmrvl files for similar cleanups, so
> anyway:
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Thank you!

-- 
With Best Regards,
Andy Shevchenko