Re: [PATCH net-next v1 1/1] nfc: mrvl: Don't use "proxy" headers

From: Krzysztof Kozlowski
Date: Mon Nov 04 2024 - 04:10:27 EST


On 04/11/2024 09:07, Andy Shevchenko wrote:
> On Sat, Nov 02, 2024 at 09:00:04AM +0100, Krzysztof Kozlowski wrote:
>> On 01/11/2024 09:39, Andy Shevchenko wrote:
>>> Update header inclusions to follow IWYU (Include What You Use)
>>> principle.
>
> ...
>
>>> -#include <linux/module.h>
>>> #include <linux/delay.h>
>>> -#include <linux/of_gpio.h>
>>> +#include <linux/device.h>
>>> +#include <linux/err.h>
>>> +#include <linux/module.h>
>>> +#include <linux/of.h>
>>> +#include <linux/printk.h>
>>
>> Do we really include printk?
>
> Yes, we use it here.

Yes, I know, I meant if this is actual practice and coding style,
regardless of IWYU.

Best regards,
Krzysztof