[PATCH] RAS/AMD/ATL: Fix unintended sign extension issue from coverity
From: Karan Sanghavi
Date: Mon Nov 04 2024 - 13:34:43 EST
Explicit cast pc to u32 to avoid sign extension while left shift
Issue reported by coverity with CID: 1593397
Signed-off-by: Karan Sanghavi <karansanghvi98@xxxxxxxxx>
---
Coverity Link:
https://scan7.scan.coverity.com/#/project-view/51975/11354?selectedIssue=1593397
---
drivers/ras/amd/atl/umc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ras/amd/atl/umc.c b/drivers/ras/amd/atl/umc.c
index dc8aa12f63c8..916c867faaf8 100644
--- a/drivers/ras/amd/atl/umc.c
+++ b/drivers/ras/amd/atl/umc.c
@@ -293,7 +293,7 @@ static unsigned long convert_dram_to_norm_addr_mi300(unsigned long addr)
}
/* PC bit */
- addr |= pc << bit_shifts.pc;
+ addr |= (u32)pc << bit_shifts.pc;
/* SID bits */
for (i = 0; i < NUM_SID_BITS; i++) {
---
base-commit: 81983758430957d9a5cb3333fe324fd70cf63e7e
change-id: 20241104-coverity1593397signextension-78c9b2c21d51
Best regards,
--
Karan Sanghavi <karansanghvi98@xxxxxxxxx>