Re: [PATCH RFC 4/7] x86/microcode/intel: Prepare for microcode staging

[Chang S. Bae]

On 11/4/2024 8:08 AM, Dave Hansen wrote:
> On 11/4/24 03:16, Borislav Petkov wrote:
> > On Tue, Oct 01, 2024 at 09:10:39AM -0700, Chang S. Bae wrote:
> > > +static inline u64 staging_addr(u32 cpu)
> > > +{
> > > +	u32 lo, hi;
> > > +
> > > +	rdmsr_on_cpu(cpu, MSR_IA32_MCU_STAGING_MBOX_ADDR, &lo, &hi);
> > > +	return lo | ((u64)hi << 32);
> > > +}
> > A single usage site. Move its code there and get rid of the function.
>
> Yeah, and it'll look a lot nicer if you use:
>
> 	rdmsrl_on_cpu(cpu, MSR_IA32_MCU_STAGING_MBOX_ADDR, &addr);
>
> and don't have to do the high/lo munging.

Oh, silly me missed this function. Thanks.