Re: [PATCH v6 7/7] arm64: dts: qcom: ipq5424: Add thermal zone nodes
From: Manikanta Mylavarapu
Date: Wed Nov 06 2024 - 03:47:53 EST
On 11/4/2024 7:21 PM, Konrad Dybcio wrote:
> On 4.11.2024 1:44 PM, Manikanta Mylavarapu wrote:
>> Add thermal zone nodes for sensors present in IPQ5424.
>>
>> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@xxxxxxxxxxx>
>> ---
> [...]
>
>> +
>> + cpu3-thermal {
>> + polling-delay-passive = <0>;
>> + polling-delay = <0>;
>> + thermal-sensors = <&tsens 13>;
>> +
>> + trips {
>> + cpu-critical {
>> + temperature = <120000>;
>> + hysteresis = <9000>;
>> + type = "critical";
>> + };
>> +
>> + cpu-passive {
>> + temperature = <110000>;
>> + hysteresis = <9000>;
>> + type = "passive";
>
> You have a passive trip point without passive polling
>
Okay, will remove this.
>> + };
>> + };
>> + };
>> +
>> + wcss-tile2-thermal {
>> + polling-delay-passive = <0>;
>> + polling-delay = <0>;
>
> These are the defaults
>
Okay, sure. I will remove.
>> + thermal-sensors = <&tsens 9>;
>> +
>> + trips {
>> + wcss_tile2-critical {
>
> Node names must not contain underscores
>
Okay, sure. I will remove.
Thanks & Regards,
Manikanta.