Re: [PATCH v6 7/7] arm64: dts: qcom: ipq5424: Add thermal zone nodes

From: Konrad Dybcio
Date: Wed Nov 06 2024 - 04:13:25 EST




On 11/6/24 09:47, Manikanta Mylavarapu wrote:


On 11/4/2024 7:21 PM, Konrad Dybcio wrote:
On 4.11.2024 1:44 PM, Manikanta Mylavarapu wrote:
Add thermal zone nodes for sensors present in IPQ5424.

Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@xxxxxxxxxxx>
---
[...]

+
+ cpu3-thermal {
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
+ thermal-sensors = <&tsens 13>;
+
+ trips {
+ cpu-critical {
+ temperature = <120000>;
+ hysteresis = <9000>;
+ type = "critical";
+ };
+
+ cpu-passive {
+ temperature = <110000>;
+ hysteresis = <9000>;
+ type = "passive";

You have a passive trip point without passive polling


Okay, will remove this.

You most likely want to preserve it, while keeping a sensible
polling frequency, so that userspace will be aware of the current
CPU temperature. <100> sounds like a sensible value here.

Konrad