RE: [PATCH net-next v3 1/2] ptp: add control over HW timestamp latch point
From: Kubalewski, Arkadiusz
Date: Thu Nov 07 2024 - 04:01:53 EST
>From: Jakub Kicinski <kuba@xxxxxxxxxx>
>Sent: Wednesday, November 6, 2024 3:05 AM
>
>On Wed, 6 Nov 2024 02:07:55 +0100 Arkadiusz Kubalewski wrote:
>> +What: /sys/class/ptp/ptp<N>/ts_point
>> +Date: October 2024
>> +Contact: Arkadiusz Kubalewski <arkadiusz.kubalewski@xxxxxxxxx>
>> +Description:
>> + This file provides control over the point in time in
>> + which the HW timestamp is latched. As specified in IEEE
>> + 802.3cx, the latch point can be either at the beginning
>> + or after the end of Start of Frame Delimiter (SFD).
>> + Value "1" means the timestamp is latched at the
>> + beginning of the SFD. Value "2" means that timestamp is
>> + latched after the end of SFD.
>
>Richard has the final say but IMO packet timestamping config does not
>belong to the PHC, rather ndo_hwtstamp_set.
Ok, thank you for feedback.
Richard do you agree with Kuba?
Thank you!
Arkadiusz