Re: [PATCH net-next v3 1/2] ptp: add control over HW timestamp latch point

[Richard Cochran]

On Thu, Nov 07, 2024 at 09:01:41AM +0000, Kubalewski, Arkadiusz wrote:
> >From: Jakub Kicinski <kuba@xxxxxxxxxx>
> >Sent: Wednesday, November 6, 2024 3:05 AM
> >Richard has the final say but IMO packet timestamping config does not
> >belong to the PHC, rather ndo_hwtstamp_set.

Right, PHC means the hardware clock.  That is distinct from the time
stamping settings.  These belong to the network device, and are
contolled by using the SIOCSHWTSTAMP ioctl.

> Ok, thank you for feedback.
> 
> Richard do you agree with Kuba?

IMO, setting the time stamp point should be with an ioctl in a way
similar way to SIOCSHWTSTAMP.

Thanks,
Richard