Re: [PATCH v3 1/1] x86/cpu: Make sure flag_is_changeable_p() is always being used

[H. Peter Anvin]

On November 8, 2024 10:29:02 AM GMT+01:00, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>On Tue, Sep 10, 2024 at 11:42:42AM +0300, Andy Shevchenko wrote:
>> When flag_is_changeable_p() is unused, it prevents kernel builds
>> with clang, `make W=1` and CONFIG_WERROR=y:
>> 
>> arch/x86/kernel/cpu/common.c:351:19: error: unused function 'flag_is_changeable_p' [-Werror,-Wunused-function]
>>   351 | static inline int flag_is_changeable_p(u32 flag)
>>       |                   ^~~~~~~~~~~~~~~~~~~~
>> 
>> Fix this by moving core around to make sure flag_is_changeable_p() is
>> always being used.
>> 
>> See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static
>> inline functions for W=1 build").
>
>Any comments on this? Can it be applied?
>

Incidentally, this really should be "unsigned long" rather than u32, although I believe it is only used on 32 bits.