Re: [PATCH 0/3] arm64: dts: qcom: x1e80100: Fix missing address/size cells warnings

From: Dmitry Baryshkov
Date: Fri Nov 08 2024 - 17:49:40 EST


On Sat, 9 Nov 2024 at 00:05, Abel Vesa <abel.vesa@xxxxxxxxxx> wrote:
>
> The commit 4b28a0dec185 ("of: WARN on deprecated #address-cells/#size-cells
> handling") now forces all parent nodes to describe the #adress-cells
> and #size-cells, otherwise it will throw a warning.
>
> Note that this patch is currently only in -next.
>
> Fix all warnings on the X Elite by adding these two properties to all
> parent nodes that don't have them.

The individual patches are incorrect per my understanding. None of
those child nodes use addressing, so adding #address-cells = <1> is
incorrect. Maybe it should be #address-cells = <0>, but that looks a
bit ridiculous to me.

>
> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
> ---
> Abel Vesa (3):
> arm64: dts: qcom: x1e80100: Add missing #address-cells/#size-cells to firmware node
> arm64: dts: qcom: x1e80100: Add missing #address-cells/#size-cells to ADSP GPR nodes
> arm64: dts: qcom: x1e80100-pmics: Add missing #address-cells/#size-cells to pmk8550_pon
>
> arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi | 3 +++
> arch/arm64/boot/dts/qcom/x1e80100.dtsi | 10 ++++++++++
> 2 files changed, 13 insertions(+)
> ---
> base-commit: 929beafbe7acce3267c06115e13e03ff6e50548a
> change-id: 20241108-x1e80100-fix-address-size-cells-missing-warnings-1cfba11bfdbd
>
> Best regards,
> --
> Abel Vesa <abel.vesa@xxxxxxxxxx>
>


--
With best wishes
Dmitry