Re: [PATCH v5 03/28] media: iris: implement iris v4l2 file ops

[Bryan O'Donoghue]

On 05/11/2024 06:55, Dikshita Agarwal wrote:
> Implement open, close and poll ops.
>
> Open:
> Configure the vb2 queue and v4l2 file handler. Allocate a video instance
> and add the instance to core instance list.
>
> Close:
> Free the instance and remove it from core instance list.

Its a bit odd that you describe the purpose of open and close but not 
poll, despite listing poll along with open and close at the very top.

Consider adding that text if you do a next version.

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>

---
bod