Re: [PATCH v5 03/28] media: iris: implement iris v4l2 file ops

[Dikshita Agarwal]

On 11/10/2024 8:40 AM, Bryan O'Donoghue wrote:
> On 05/11/2024 06:55, Dikshita Agarwal wrote:
>> Implement open, close and poll ops.
>>
>> Open:
>> Configure the vb2 queue and v4l2 file handler. Allocate a video instance
>> and add the instance to core instance list.
>>
>> Close:
>> Free the instance and remove it from core instance list.
> 
> Its a bit odd that you describe the purpose of open and close but not poll,
> despite listing poll along with open and close at the very top.
> 
> Consider adding that text if you do a next version.
> 
We didn't describe the poll since we are making use of m2m API for that.
but sure can describe that as well.

Thanks,
Dikshita
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> 
> ---
> bod