Re: [PATCH v2] soc: ti: pruss: remove misplaced semicolon from pruss_cfg_xfr_enable
From: Nishanth Menon
Date: Mon Nov 11 2024 - 07:39:48 EST
On 14:32-20241111, Roger Quadros wrote:
>
>
> On 09/11/2024 05:26, guanjing wrote:
> > Remove misplaced colon in inline variant of pruss_cfg_xfr_enable()
>
> s/colon/semicolon
>
> > which results in a syntax error when the code is compiled without
> > CONFIG_TI_PRUSS.
> >
> > Fixes: 0211cc1e4fbb ("soc: ti: pruss: Add helper functions to set GPI mode, MII_RT_event and XFR")
> > Signed-off-by: guanjing <guanjing@xxxxxxxxxxxxxxxxxxxx>
>
> Reviewed-by: Roger Quadros <rogerq@xxxxxxxxxx>
https://lore.kernel.org/all/Zy3nBW3XvFy-Y1Fe@xxxxxxxxxx/
Please also add to the commit message what Simon suggested (Found using ..)
- how was this found? That helps other folks learn better practises.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D