Re: [PATCH] clk: qcom: remove unused data from gcc-ipq5424.c

From: Dmitry Baryshkov
Date: Mon Nov 11 2024 - 07:41:20 EST


On Mon, Nov 11, 2024 at 11:32:51AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The newly added driver causes a warnings when enabling -Wunused-const-variables:
>
> drivers/clk/qcom/gcc-ipq5424.c:1064:30: error: 'ftbl_gcc_q6_axi_clk_src' defined but not used [-Werror=unused-const-variable=]
> 1064 | static const struct freq_tbl ftbl_gcc_q6_axi_clk_src[] = {
> | ^~~~~~~~~~~~~~~~~~~~~~~
> drivers/clk/qcom/gcc-ipq5424.c:957:30: error: 'ftbl_gcc_qpic_clk_src' defined but not used [-Werror=unused-const-variable=]
> 957 | static const struct freq_tbl ftbl_gcc_qpic_clk_src[] = {
> | ^~~~~~~~~~~~~~~~~~~~~
> drivers/clk/qcom/gcc-ipq5424.c:497:30: error: 'ftbl_gcc_qupv3_2x_core_clk_src' defined but not used [-Werror=unused-const-variable=]
> 497 | static const struct freq_tbl ftbl_gcc_qupv3_2x_core_clk_src[] = {
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> In order to hopefully enable this warning by default in the future,
> remove the data for now. If it gets used in the future, it can
> trivially get added back.
>
> Fixes: 21b5d5a4a311 ("clk: qcom: add Global Clock controller (GCC) driver for IPQ5424 SoC")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> drivers/clk/qcom/gcc-ipq5424.c | 18 ------------------
> 1 file changed, 18 deletions(-)
>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

--
With best wishes
Dmitry