RE: [PATCH v4 8/8] x86/mce: Fix typos

From: Zhuo, Qiuxu
Date: Wed Nov 13 2024 - 10:07:41 EST


Hi Yazen,

> From: Yazen Ghannam <yazen.ghannam@xxxxxxx>
> [...]
> > @@ -1144,7 +1144,7 @@ static noinstr int mce_start(int *no_way_out)
> > } else {
> > /*
> > * Subject: Now start the scanning loop one by one in
> > - * the original callin order.
> > + * the original calling order.
>
> I don't think this is a typo. It seems to refer to the mce_callin variable/idea.
>
> For example, each CPU "calls in" when ready. This is independent of when
> each CPU is "called" to do something.
>
> CPUs are called in this order 0, 1, 2.
> CPUs "call in" in this order 1, 0, 2.
>
> When a CPU is called can be different from when it responds.
>
> Maybe I'm reading too much into this. :/

Too finicky to me :(
But I appreciate you sharing your reading and thoughts. 😊

-Qiuxu