RE: [PATCH v4 8/8] x86/mce: Fix typos

From: Zhuo, Qiuxu
Date: Wed Nov 13 2024 - 20:21:01 EST


> From: Yazen Ghannam <yazen.ghannam@xxxxxxx>
> [...]
> > >> - * disable GART TBL walk error reporting, which
> > >> + * disable GART TLB walk error reporting, which
> > >
> > > This also is not a typo. TBL -> table
> > >
> > > From old AMD K8 BKDG document:
> > > 10 GartTblWkEn GART Table Walk Error Reporting Enable R/W 0
> > >
> >
> > There is another comment in init_amd_gh() that seems to be related to
> > the same thing and similarly worded. That seems to refer to TLB
> > instead of TBL(table).
> >
> > /*
> > * Disable GART TLB Walk Errors on Fam10h. We do this here because
> > this
> > * is always needed when GART is enabled, even in a kernel which has
> > no
> > * MCE support built in. BIOS should disable GartTlbWlk Errors already.
> > * If it doesn't, we do it here as suggested by the BKDG.
> > *
> > * Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=33012
> > */

Thanks Sohil for this reference.

> > msr_set_bit(MSR_AMD64_MCx_MASK(4), 10);
> >
> >
>
> Now I think *that* is a typo, since it doesn't match the documentation.
> :)

As Yazen has the documentation that says TBL (table) is the intended meaning.
I'll drop this patch in next version.

-Qiuxu