Re: [PATCH] mm: Remove 'return;' at the end of void cma_activate_area()

From: SeongJae Park
Date: Tue Nov 19 2024 - 14:13:54 EST


Hello,

On Tue, 19 Nov 2024 19:59:40 +0800 winterver <295107659@xxxxxx> wrote:

> From: Jiale Yang <295107659@xxxxxx>
>
> Remove 'return;' at the end of void cma_activate_area(). It's a void
> function, so an ending return statement is unnecessary.
>
> Signed-off-by: Jiale Yang <295107659@xxxxxx>
> ---
> mm/cma.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/cma.c b/mm/cma.c
> index 2d9fae939..070399bce 100644
> --- a/mm/cma.c
> +++ b/mm/cma.c
> @@ -135,7 +135,6 @@ static void __init cma_activate_area(struct cma *cma)
> totalcma_pages -= cma->count;
> cma->count = 0;
> pr_err("CMA area %s could not be activated\n", cma->name);
> - return;
> }

Looks good to me. But, seems a same change[1] from Pintu Kumar has already
merged into mm-unstable?

[1] https://lore.kernel.org/20240927181637.19941-1-quic_pintu@xxxxxxxxxxx


Thanks,
SJ

>
> static int __init cma_init_reserved_areas(void)
> --
> 2.43.0