Re: [PATCH net] netpoll: Use rtnl_dereference() for npinfo pointer access

From: Eric Dumazet
Date: Fri Nov 22 2024 - 04:18:56 EST


On Fri, Nov 22, 2024 at 4:56 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Fri, 22 Nov 2024 00:41:14 +0100 Eric Dumazet wrote:
> > > Fixes: c75964e40e69 ("netpoll: Use rtnl_dereference() for npinfo pointer access")
> >
> > This seems wrong. This sha1 does not exist, and the title is this patch.
> >
> > We do not send a patch saying it is fixing itself.
> >
> > I would suggest instead :
> >
> > Fixes: c69c5e10adb9 ("netpoll: Use rcu_access_pointer() in __netpoll_setup")
>
> Or no Fixes tag and net-next...
>
> I'm missing what can go wrong here, seems like a cleanup.

Nothing wrong, perhaps add a Link: next time to avoid confusion

https://lore.kernel.org/lkml/Zz1cKZYt1e7elibV@xxxxxxxxxxxxxxxxxxx/