Re: [PATCH net] netpoll: Use rtnl_dereference() for npinfo pointer access
From: Breno Leitao
Date: Fri Nov 22 2024 - 04:31:27 EST
On Thu, Nov 21, 2024 at 07:56:16PM -0800, Jakub Kicinski wrote:
> On Fri, 22 Nov 2024 00:41:14 +0100 Eric Dumazet wrote:
> > > Fixes: c75964e40e69 ("netpoll: Use rtnl_dereference() for npinfo pointer access")
> >
> > This seems wrong. This sha1 does not exist, and the title is this patch.
> >
> > We do not send a patch saying it is fixing itself.
> >
> > I would suggest instead :
> >
> > Fixes: c69c5e10adb9 ("netpoll: Use rcu_access_pointer() in __netpoll_setup")
>
> Or no Fixes tag and net-next...
>
> I'm missing what can go wrong here, seems like a cleanup.
I decide to sent to net due Herbert's concern about the previous patch.
I will send a v2 targeting net-next, then.
Thanks for the review,
--breno