Re: [PATCH v3 1/5] sched_ext: Implement scx_rq_clock_update/stale()

[Changwoo Min]

Hello,

On 24. 12. 4. 08:23, Tejun Heo wrote:
> Hello,
>
> On Tue, Dec 03, 2024 at 11:27:58PM +0900, Changwoo Min wrote:
> ...
> > @@ -2505,19 +2538,6 @@ extern const struct sched_class rt_sched_class;
> >   extern const struct sched_class fair_sched_class;
> >   extern const struct sched_class idle_sched_class;
> >   
> > -#ifdef CONFIG_SCHED_CLASS_EXT
> > -extern const struct sched_class ext_sched_class;
> > -
> > -DECLARE_STATIC_KEY_FALSE(__scx_ops_enabled);	/* SCX BPF scheduler loaded */
> > -DECLARE_STATIC_KEY_FALSE(__scx_switched_all);	/* all fair class tasks on SCX */
> > -
> > -#define scx_enabled()		static_branch_unlikely(&__scx_ops_enabled)
> > -#define scx_switched_all()	static_branch_unlikely(&__scx_switched_all)
> > -#else /* !CONFIG_SCHED_CLASS_EXT */
> > -#define scx_enabled()		false
> > -#define scx_switched_all()	false
> > -#endif /* !CONFIG_SCHED_CLASS_EXT */
>
> Can you please separate out code relocations into a separate patch? Here,
> it's on the smaller side but patches are difficult to read when they're
> mixed up.

Thanks for the comment! I will separate the code relocation out
in the next version.

Regards,
Changwoo Min