Re: [PATCH net-next v3 09/10] net: freescale: ucc_geth: Introduce a helper to check Reduced modes

[Maxime Chevallier]

Hello Andrew,

On Wed, 4 Dec 2024 03:15:52 +0100
Andrew Lunn <andrew@xxxxxxx> wrote:

> > +static bool phy_interface_mode_is_reduced(phy_interface_t interface)
> > +{
> > +	return phy_interface_mode_is_rgmii(interface) ||
> > +	       interface == PHY_INTERFACE_MODE_RMII ||
> > +	       interface == PHY_INTERFACE_MODE_RTBI;
> > +}  
> 
> I wounder if this is useful anywhere else? Did you take a look around
> other MAC drivers? Maybe this should be in phy.h?

Yes I did consider it but it looks like ucc_geth is the only driver
that has a configuration that applies to all R(MII/GMII/TBI) interfaces
:/ I didn't even know about RTBI mode before looking at that driver and
it does look like it's not supported by that many devices... I'd be
happy to put that in phy.h but I think ucc_geth is going to be the sole
user :)

Thanks,

Maxime