Re: [PATCH net-next v3 09/10] net: freescale: ucc_geth: Introduce a helper to check Reduced modes

[Andrew Lunn]

On Wed, Dec 04, 2024 at 09:22:32AM +0100, Maxime Chevallier wrote:
> Hello Andrew,
> 
> On Wed, 4 Dec 2024 03:15:52 +0100
> Andrew Lunn <andrew@xxxxxxx> wrote:
> 
> > > +static bool phy_interface_mode_is_reduced(phy_interface_t interface)
> > > +{
> > > +	return phy_interface_mode_is_rgmii(interface) ||
> > > +	       interface == PHY_INTERFACE_MODE_RMII ||
> > > +	       interface == PHY_INTERFACE_MODE_RTBI;
> > > +}  
> > 
> > I wounder if this is useful anywhere else? Did you take a look around
> > other MAC drivers? Maybe this should be in phy.h?
> 
> Yes I did consider it but it looks like ucc_geth is the only driver
> that has a configuration that applies to all R(MII/GMII/TBI) interfaces

O.K. What is important is you considered it. Thanks. Too many
developers are focus on just their driver and don't think about other
drivers and code reuse.

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew