Re: [PATCH net] qca_spi: Fix clock speed for multiple QCA7000
From: Jakub Kicinski
Date: Thu Dec 05 2024 - 19:50:21 EST
On Thu, 5 Dec 2024 12:07:21 +0100 Stefan Wahren wrote:
> > I think we should also delete the (seemingly unused?) qca->clkspeed
> > in this change. Otherwise it looks surprising that we still assign
> > the module param to it?
> Good catch! But shouldn't this be a separate clean-up, because the
> clkspeed was already unused before?
I'd put it in the same change for the sake of backporters.
Otherwise they may worry there was an intermediate patch,
or perhaps there even is one, I haven't checked.
If we delete the field and the assignment - if the backport
compiles its probably correct.