Re: [PATCH net] qca_spi: Fix clock speed for multiple QCA7000

[Stefan Wahren]

Hi Jakub,

Am 05.12.24 um 03:48 schrieb Jakub Kicinski:
> On Mon,  2 Dec 2024 16:58:53 +0100 Stefan Wahren wrote:
> > Storing the maximum clock speed in module parameter qcaspi_clkspeed
> > has the unintended side effect that the first probed instance
> > defines the value for all other instances. Fix this issue by storing
> > it in max_speed_hz of the relevant SPI device.
> >
> > This fix keeps the priority of the speed parameter (module parameter,
> > device tree property, driver default).
> I think we should also delete the (seemingly unused?) qca->clkspeed
> in this change. Otherwise it looks surprising that we still assign
> the module param to it?
Good catch! But shouldn't this be a separate clean-up, because the
clkspeed was already unused before?