Re: [PATCH net] qca_spi: Fix clock speed for multiple QCA7000
From: Jakub Kicinski
Date: Wed Dec 04 2024 - 21:49:05 EST
On Mon, 2 Dec 2024 16:58:53 +0100 Stefan Wahren wrote:
> Storing the maximum clock speed in module parameter qcaspi_clkspeed
> has the unintended side effect that the first probed instance
> defines the value for all other instances. Fix this issue by storing
> it in max_speed_hz of the relevant SPI device.
>
> This fix keeps the priority of the speed parameter (module parameter,
> device tree property, driver default).
I think we should also delete the (seemingly unused?) qca->clkspeed
in this change. Otherwise it looks surprising that we still assign
the module param to it?
--
pw-bot: cr