Re: [PATCH 3/4] arm64: dts: qcom: sm8750-mtp: Enable CDSP and mention MPSS
From: Krzysztof Kozlowski
Date: Fri Dec 06 2024 - 03:56:18 EST
On 05/12/2024 18:34, Konrad Dybcio wrote:
> On 22.11.2024 4:26 PM, Krzysztof Kozlowski wrote:
>> Enable the CDSP on MPT8750 board and add firmware for the modem, however
>> keep it as failed because modem crashes after booting for unknown
>> reasons.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>> ---
>> arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
>> index 8eeed7f2f7766326cfc7830002768087e9783b9b..e2562ea5996ddfb1bee03b367082f4e1890131f3 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
>> @@ -791,6 +791,21 @@ &remoteproc_adsp {
>> status = "okay";
>> };
>>
>> +&remoteproc_cdsp {
>> + firmware-name = "qcom/sm8750/cdsp.mbn",
>> + "qcom/sm8750/cdsp_dtb.mbn";
>> +
>> + status = "okay";
>> +};
>> +
>> +&remoteproc_mpss {
>> + firmware-name = "qcom/sm8750/modem.mbn",
>> + "qcom/sm8750/modem_dtb.mbn";
>> +
>> + /* Modem crashes with "DOG detects stalled initialization" */
>> + status = "fail";
>
> That is a bad sign, let's hold off merging this as we may be
> missing some resource..
Luckily there are reports that all modems on recent boards crash (sm8550
and newer), so probably nothing wrong was in this DTS. :)
Best regards,
Krzysztof