Re: [PATCH net-next v1 02/21] net: usb: lan78xx: Remove KSZ9031 PHY fixup
From: Oleksij Rempel
Date: Fri Dec 06 2024 - 03:56:54 EST
Hi Simon,
On Thu, Dec 05, 2024 at 05:12:03PM +0000, Simon Horman wrote:
> > - dev->interface = PHY_INTERFACE_MODE_RGMII;
> > - /* external PHY fixup for KSZ9031RNX */
> > - ret = phy_register_fixup_for_uid(PHY_KSZ9031RNX, 0xfffffff0,
> > - ksz9031rnx_fixup);
> > - if (ret < 0) {
> > - netdev_err(dev->net, "Failed to register fixup for PHY_KSZ9031RNX\n");
> > - return NULL;
> > - }
> > + dev->interface = PHY_INTERFACE_MODE_RGMII_ID;
> > + /* The PHY driver is responsible to configure proper RGMII
> > + * interface delays. Disable RGMII delays on MAC side.
> > + */
> > + lan78xx_write_reg(dev, MAC_RGMII_ID, 0);
> >
> > phydev->is_internal = false;
> > }
>
> nit: With this change ret is now set but otherwise unused in this function.
>
> I would suggest a new patch, prior to this one, that drops the
> other places where it is set. They seem to have no effect.
> And then remove ret from this function in this patch.
>
There is a patch in this patch stack which will address it too. There is
just limit to amount of patches I can upstream per one round.
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |