Re: [PATCH] ubifs/debug: remove return from end of void function

[Zhihao Cheng]

在 2024/12/6 20:52, Pintu Kumar 写道:
> Noticed that there is a useless return statement at the end of void
> function ubifs_dump_leb().
> Just removed it.
>
> Signed-off-by: Pintu Kumar <quic_pintu@xxxxxxxxxxx>
> ---
>   fs/ubifs/debug.c | 1 -
>   1 file changed, 1 deletion(-)

Hi, Pintu. The title of the patch should be something like "ubifs: 
ubifs_dump_leb: remove return at end of void function". See 
Documentation/process/submitting-patches.rst. Otherwise,

Reviewed-by: Zhihao Cheng <chengzhihao1@xxxxxxxxxx>

> diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c
> index 5cc69beaa62e..987eb5b6782a 100644
> --- a/fs/ubifs/debug.c
> +++ b/fs/ubifs/debug.c
> @@ -863,7 +863,6 @@ void ubifs_dump_leb(const struct ubifs_info *c, int lnum)
>   
>   out:
>   	vfree(buf);
> -	return;
>   }
>   
>   void ubifs_dump_znode(const struct ubifs_info *c,