Re: [PATCH] ubifs/debug: remove return from end of void function

[Pintu Agarwal]

Hi Zhihao,

On Sat, 7 Dec 2024 at 08:25, Zhihao Cheng <chengzhihao1@xxxxxxxxxx> wrote:
>
> 在 2024/12/6 20:52, Pintu Kumar 写道:
> > Noticed that there is a useless return statement at the end of void
> > function ubifs_dump_leb().
> > Just removed it.
> >
> > Signed-off-by: Pintu Kumar <quic_pintu@xxxxxxxxxxx>
> > ---
> >   fs/ubifs/debug.c | 1 -
> >   1 file changed, 1 deletion(-)
>
> Hi, Pintu. The title of the patch should be something like "ubifs:
> ubifs_dump_leb: remove return at end of void function". See
> Documentation/process/submitting-patches.rst. Otherwise,
>
> Reviewed-by: Zhihao Cheng <chengzhihao1@xxxxxxxxxx>
>
Thank you so much for your review and comments.
Oh, normally I follow "subsystem: filename: <title>" for the other patches.
Okay, no worries, I can follow your suggestion as "subsystem: function-name"
and push changes again for both the patches.

Actually, sometimes, function-name can be quite big, so I avoid it in
subject titles.
But no issues, I can change it and push again.

Thank you,
Regards,
Pintu