Re: [PATCH 2/2] auxdisplay: img-ascii-lcd: Constify struct img_ascii_lcd_config

[Geert Uytterhoeven]

On Fri, Dec 6, 2024 at 11:26 PM Christophe JAILLET
<christophe.jaillet@xxxxxxxxxx> wrote:
> 'struct img_ascii_lcd_config' is not modified in this driver.
>
> Constifying this structure moves some data to a read-only section, so
> increase overall security, especially when the structure holds some
> function pointers.
>
> On a x86_64, with allmodconfig:
> Before:
> ======
>    text    data     bss     dec     hex filename
>    6110     728       0    6838    1ab6 drivers/auxdisplay/img-ascii-lcd.o
>
> After:
> =====
>    text    data     bss     dec     hex filename
>    6198     632       0    6830    1aae drivers/auxdisplay/img-ascii-lcd.o
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds