Re: [PATCH 2/2] auxdisplay: img-ascii-lcd: Constify struct img_ascii_lcd_config

[Andy Shevchenko]

On Mon, Dec 09, 2024 at 09:55:48AM +0100, Geert Uytterhoeven wrote:
> On Fri, Dec 6, 2024 at 11:26 PM Christophe JAILLET
> <christophe.jaillet@xxxxxxxxxx> wrote:
> > 'struct img_ascii_lcd_config' is not modified in this driver.
> >
> > Constifying this structure moves some data to a read-only section, so
> > increase overall security, especially when the structure holds some
> > function pointers.
> >
> > On a x86_64, with allmodconfig:
> > Before:
> > ======
> >    text    data     bss     dec     hex filename
> >    6110     728       0    6838    1ab6 drivers/auxdisplay/img-ascii-lcd.o
> >
> > After:
> > =====
> >    text    data     bss     dec     hex filename
> >    6198     632       0    6830    1aae drivers/auxdisplay/img-ascii-lcd.o
> >
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> 
> Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Pushed to my review and testing queue, thanks!

-- 
With Best Regards,
Andy Shevchenko