Re: [PATCH] KVM: arm64: nv: Set ISTATUS for emulated timers, If timer expired

From: kernel test robot
Date: Mon Dec 09 2024 - 14:37:14 EST


Hi Ganapatrao,

kernel test robot noticed the following build warnings:

[auto build test WARNING on kvmarm/next]
[also build test WARNING on arm64/for-next/core soc/for-next linus/master arm/for-next arm/fixes v6.13-rc2 next-20241209]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Ganapatrao-Kulkarni/KVM-arm64-nv-Set-ISTATUS-for-emulated-timers-If-timer-expired/20241209-133651
base: https://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm.git next
patch link: https://lore.kernel.org/r/20241209053201.339939-1-gankulkarni%40os.amperecomputing.com
patch subject: [PATCH] KVM: arm64: nv: Set ISTATUS for emulated timers, If timer expired
config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20241210/202412100311.HEYAT0bx-lkp@xxxxxxxxx/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241210/202412100311.HEYAT0bx-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412100311.HEYAT0bx-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> arch/arm64/kvm/arch_timer.c:1202:3: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
1202 | struct timer_map map;
| ^
1 warning generated.


vim +1202 arch/arm64/kvm/arch_timer.c

1190
1191 static void kvm_arm_timer_write(struct kvm_vcpu *vcpu,
1192 struct arch_timer_context *timer,
1193 enum kvm_arch_timer_regs treg,
1194 u64 val)
1195 {
1196 switch (treg) {
1197 case TIMER_REG_TVAL:
1198 timer_set_cval(timer, kvm_phys_timer_read() - timer_get_offset(timer) + (s32)val);
1199 break;
1200
1201 case TIMER_REG_CTL:
> 1202 struct timer_map map;
1203
1204 val &= ~ARCH_TIMER_CTRL_IT_STAT;
1205 get_timer_map(vcpu, &map);
1206 /* Set ISTATUS bit for emulated timers, if timer expired. */
1207 if (timer == map.emul_vtimer || timer == map.emul_ptimer) {
1208 if (!kvm_timer_compute_delta(timer))
1209 val |= ARCH_TIMER_CTRL_IT_STAT;
1210 }
1211 timer_set_ctl(timer, val);
1212 break;
1213
1214 case TIMER_REG_CVAL:
1215 timer_set_cval(timer, val);
1216 break;
1217
1218 case TIMER_REG_VOFF:
1219 *timer->offset.vcpu_offset = val;
1220 break;
1221
1222 default:
1223 BUG();
1224 }
1225 }
1226

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki