Re: [PATCH v7 2/2] selftests/resctrl: Discover SNC kernel support and adjust messages

From: Reinette Chatre
Date: Mon Dec 09 2024 - 14:37:45 EST


Hi Maciej,

On 12/9/24 3:09 AM, Maciej Wieczor-Retman wrote:
> Resctrl selftest prints a message on test failure that Sub-Numa
> Clustering (SNC) could be enabled and points the user to check their BIOS
> settings. No actual check is performed before printing that message so
> it is not very accurate in pinpointing a problem.
>
> When there is SNC support for kernel's resctrl subsystem and SNC is
> enabled then sub node files are created for each node in the resctrlfs.
> The sub node files exist in each regular node's L3 monitoring directory.
> The reliable path to check for existence of sub node files is
> /sys/fs/resctrl/mon_data/mon_L3_00/mon_sub_L3_00.
>
> Add helper that checks for mon_sub_L3_00 existence.
>
> Correct old messages to account for kernel support of SNC in
> resctrl.
>
> Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@xxxxxxxxx>
> ---

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>

Reinette