Re: [PATCH 2/5] x86/cpu: Expose only stepping min/max interface

[Dave Hansen]

On 12/13/24 08:24, Borislav Petkov wrote:
> drivers/edac/i10nm_base.c:951:90: error: macro "X86_MATCH_VFM_STEPPINGS" requires 4 arguments, but only 3 given
>   951 |         X86_MATCH_VFM_STEPPINGS(INTEL_ATOM_DARKMONT_X,  X86_STEPPINGS(0x0, 0xf), &gnr_cfg),
>       |                                                                                          ^

I'll fix that up.

>> +	X86_MATCH_VFM_STEPPINGS(INTEL_ATOM_CRESTMONT_X,	0x0, 0xf, &gnr_cfg),
>> +	X86_MATCH_VFM_STEPPINGS(INTEL_ATOM_CRESTMONT,	0x0, 0xf, &gnr_cfg),
> 
> Aren't those supposed to be:
> 
> 	X86_MATCH_VFM_STEPPINGS(INTEL_ATOM_CRESTMONT,	X86_STEPPING_MIN, X86_STEPPING_MAX, &gnr_cfg),
> 
> And while we're adding new defines, can we shorten them too?
> 
> 	X86_MATCH_VFM_STP(INTEL_ATOM_CRESTMONT,	X86_STP_MIN, X86_STP_MAX, &gnr_cfg),
> 
> all that "STEPPING" is screaming at me! :-P

I was trying to minimize the churn but that seems like a good thing to
add.  I'll also shorten the name.