Re: [PATCH 3/4] arm64: dts: exynos: gs101-oriole: move common Pixel6 & 6Pro parts into a .dtsi
From: Peter Griffin
Date: Wed Dec 18 2024 - 07:15:33 EST
Hi André,
On Mon, 16 Dec 2024 at 13:06, André Draszik <andre.draszik@xxxxxxxxxx> wrote:
>
> In order to support Pixel 6 (Oriole) and Pixel 6 Pro (Raven) properly,
> we have to be able to distinguish them properly as we add support for
> more features.
>
> For example, Raven has a larger display. There are other differences,
> like battery design capacity, etc.
>
> Move all the parts that are common for now into a gs101-raviole.dtsi,
> and just leave the display related things in gs101-oriole.dts.
>
> Raviole was chosen as the name because Google uses that when referring
> to the combination of Oriole & Raven, keeping the familiar terminology.
As discussed off list lets not use the "raviole" terminology (as it
precludes Pixel 6a / Bluejay which is also based on gs101). I think
something like gs101-board-common.dtsi would be better.
Additionally I tested this series on a Pixel 6 Oriole device (with the
latest Yocto initramfs) and the frame-buffer was functional.
With the above comments addressed
Reviewed-by: Peter Griffin <peter.griffin@xxxxxxxxxx>
Tested-by: Peter Griffin <peter.griffin@xxxxxxxxxx>
regards,
Peter