Re: [PATCH v3] staging: gpib: Add error handling

[kernel test robot]

Hi Nihar,

kernel test robot noticed the following build errors:

[auto build test ERROR on staging/staging-testing]

url:    https://github.com/intel-lab-lkp/linux/commits/Nihar-Chaithanya/staging-gpib-Add-error-handling/20241222-060646
base:   staging/staging-testing
patch link:    https://lore.kernel.org/r/20241221214822.163667-1-niharchaithanya%40gmail.com
patch subject: [PATCH v3] staging: gpib: Add error handling
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20241222/202412221339.S4dQNJOs-lkp@xxxxxxxxx/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241222/202412221339.S4dQNJOs-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412221339.S4dQNJOs-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

   In file included from drivers/staging/gpib/fmh_gpib/fmh_gpib.c:15:
   In file included from drivers/staging/gpib/fmh_gpib/fmh_gpib.h:9:
   In file included from include/linux/dmaengine.h:8:
   In file included from include/linux/device.h:32:
   In file included from include/linux/device/driver.h:21:
   In file included from include/linux/module.h:19:
   In file included from include/linux/elf.h:6:
   In file included from arch/s390/include/asm/elf.h:181:
   In file included from arch/s390/include/asm/mmu_context.h:11:
   In file included from arch/s390/include/asm/pgalloc.h:18:
   In file included from include/linux/mm.h:2223:
   include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     504 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     505 |                            item];
         |                            ~~~~
   include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     511 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     512 |                            NR_VM_NUMA_EVENT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~~
   include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
     518 |         return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
         |                               ~~~~~~~~~~~ ^ ~~~
   include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     524 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     525 |                            NR_VM_NUMA_EVENT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/gpib/fmh_gpib/fmh_gpib.c:162:45: warning: bitwise operation between different enumeration types ('enum fmh_gpib_auxmr_bits' and 'enum aux_reg_i_bits') [-Wenum-enum-conversion]
     162 |                 write_byte(&priv->nec7210_priv, AUX_I_REG | LOCAL_PPOLL_MODE_BIT, AUXMR);
         |                                                 ~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~
>> drivers/staging/gpib/fmh_gpib/fmh_gpib.c:1694:8: error: use of undeclared label 'err_platform_driver'
    1694 |                 goto err_platform_driver;
         |                      ^
   5 warnings and 1 error generated.


vim +/err_platform_driver +1694 drivers/staging/gpib/fmh_gpib/fmh_gpib.c

  1687	
  1688	static int __init fmh_gpib_init_module(void)
  1689	{
  1690		int result;
  1691	
  1692		result = platform_driver_register(&fmh_gpib_platform_driver);
  1693		if (result)
> 1694			goto err_platform_driver;
  1695	
  1696		result = pci_register_driver(&fmh_gpib_pci_driver);
  1697		if (result)
  1698			goto err_pci_driver;
  1699	
  1700		result = gpib_register_driver(&fmh_gpib_unaccel_interface, THIS_MODULE);
  1701		if (result)
  1702			goto err_unaccel;
  1703	
  1704		result = gpib_register_driver(&fmh_gpib_interface, THIS_MODULE);
  1705		if (result)
  1706			goto err_interface;
  1707	
  1708		result = gpib_register_driver(&fmh_gpib_pci_unaccel_interface, THIS_MODULE);
  1709		if (result)
  1710			goto err_pci_unaccel;
  1711	
  1712		result = gpib_register_driver(&fmh_gpib_pci_interface, THIS_MODULE);
  1713		if (result)
  1714			goto err_pci;
  1715	
  1716		return 0;
  1717	
  1718	err_pci:
  1719		gpib_unregister_driver(&fmh_gpib_pci_unaccel_interface);
  1720	err_pci_unaccel:
  1721		gpib_unregister_driver(&fmh_gpib_interface);
  1722	err_interface:
  1723		gpib_unregister_driver(&fmh_gpib_unaccel_interface);
  1724	err_unaccel:
  1725		pci_unregister_driver(&fmh_gpib_pci_driver);
  1726	err_pci_driver:
  1727		platform_driver_unregister(&fmh_gpib_platform_driver);
  1728	
  1729		return result;
  1730	}
  1731	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki