Re: [PATCH] staging: gpib: Rename variable ValidAll

From: Greg Kroah-Hartman
Date: Sun Dec 22 2024 - 01:11:54 EST


On Sat, Dec 21, 2024 at 08:01:23PM +0000, Antonio Riccio wrote:
> --- a/drivers/staging/gpib/uapi/gpib_user.h
> +++ b/drivers/staging/gpib/uapi/gpib_user.h
> @@ -114,7 +114,7 @@ enum bus_control_line {
> ValidSRQ = 0x20,
> ValidATN = 0x40,
> ValidEOI = 0x80,
> - ValidALL = 0xff,
> + VALIDALL = 0xff,

Why are you only changing one of these? And are you sure that these
values aren't coming from a specification with this type of naming?

thanks,

greg k-h