Re: [PATCH] staging: gpib: Rename variable ValidAll

[Dave Penkler]

On Sun, Dec 22, 2024 at 07:11:40AM +0100, Greg Kroah-Hartman wrote:
> On Sat, Dec 21, 2024 at 08:01:23PM +0000, Antonio Riccio wrote:
> > --- a/drivers/staging/gpib/uapi/gpib_user.h
> > +++ b/drivers/staging/gpib/uapi/gpib_user.h
> > @@ -114,7 +114,7 @@ enum bus_control_line {
> >  	ValidSRQ = 0x20,
> >  	ValidATN = 0x40,
> >  	ValidEOI = 0x80,
> > -	ValidALL = 0xff,
> > +	VALIDALL = 0xff,
> 
> Why are you only changing one of these?  And are you sure that these
> values aren't coming from a specification with this type of naming?
> 
> thanks,
> 
> greg k-h
I prefer that we keep the camel case definitions in the uapi includes
as they are for now so that they remain compatible with the current
user space includes. Over time I will release a version of the user
space includes that provide compatability definitions for the
checkpatch clean version of the uapi includes. This includes the camel
case definitions and the typedefs. I will submit a patches for this in
the new year.
-dave