Re: [PATCH] perf tools: Remove unused is_executable_file

[Dr. David Alan Gilbert]

* Arnaldo Carvalho de Melo (acme@xxxxxxxxxx) wrote:
> On Sun, Dec 22, 2024 at 09:58:31PM +0000, linux@xxxxxxxxxxx wrote:
> > From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
> > 
> > is_executable_file()  has been unused since 2022's
> > commit 7391db645938 ("perf test: Refactor shell tests allowing subdirs")
> > 
> > Remove it.
> 
> Did you patch this on:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git perf-tools-next
> 
> ?

Apologies, this is on 6.13-rc4 (ish - it might have been slightly further back when
I sent it).

> 
> That function is still there, so I'll fixup your patch, keep your
> credits and test it all.

Thanks!

Dave

> Thanks,
> 
> - Arnaldo
> 
> ⬢ [acme@toolbox perf-tools-next]$ b4 am -ctsl --cc-trailers 20241222215831.283248-1-linux@xxxxxxxxxxx
> Grabbing thread from lore.kernel.org/all/20241222215831.283248-1-linux@xxxxxxxxxxx/t.mbox.gz
> Checking for newer revisions
> Grabbing search results from lore.kernel.org
> Analyzing 1 messages in the thread
> Looking for additional code-review trailers on lore.kernel.org
> Checking attestation on all messages, may take a moment...
> ---
>   ✓ [PATCH] perf tools: Remove unused is_executable_file
>     + Link: https://lore.kernel.org/r/20241222215831.283248-1-linux@xxxxxxxxxxx
>     + Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
>   ---
>   ✓ Signed: DKIM/treblig.org
> ---
> Total patches: 1
> ---
>  Link: https://lore.kernel.org/r/20241222215831.283248-1-linux@xxxxxxxxxxx
>  Base: not specified
>        git am ./20241222_linux_perf_tools_remove_unused_is_executable_file.mbx
> ⬢ [acme@toolbox perf-tools-next]$        git am ./20241222_linux_perf_tools_remove_unused_is_executable_file.mbx
> Applying: perf tools: Remove unused is_executable_file
> error: patch failed: tools/perf/util/path.h:12
> error: tools/perf/util/path.h: patch does not apply
> Patch failed at 0001 perf tools: Remove unused is_executable_file
> hint: Use 'git am --show-current-patch=diff' to see the failed patch
> hint: When you have resolved this problem, run "git am --continue".
> hint: If you prefer to skip this patch, run "git am --skip" instead.
> hint: To restore the original branch and stop patching, run "git am --abort".
> hint: Disable this message with "git config advice.mergeConflict false"
> ⬢ [acme@toolbox perf-tools-next]$
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/